Rust: Implement data flow through tuple structs #18675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/struct-tuple-field
branch
2 times, most recently
from
69251cd to
e2a78ae
Compare
hvitved
force-pushed
the
rust/struct-tuple-field
branch
from
e2a78ae to
95ab48d
Compare
There was a problem hiding this comment.
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for flow through structs that use tuple fields (
struct Foo(i64)), as opposed to structs with named fields (struct Foo{i: i64}), which are already supported.Instead of adding a fourth constructor to
TContent, I decided to instead unify the representation into just two constructorsTTupleFieldContent(TupleField field)andTRecordFieldContent(RecordField field), which both support structs as well as variants.